feat(deno): add express integration#22461
Open
isaacs wants to merge 1 commit into
Open
Conversation
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
July 21, 2026 19:35
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 21, 2026 19:36
6d5b8ae to
6237ccf
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 21, 2026 19:36
5da649b to
ad82a2a
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 21, 2026 19:49
6237ccf to
4c157ad
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 21, 2026 19:49
ad82a2a to
ba29b3a
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 21, 2026 21:43
4c157ad to
86ed574
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 21, 2026 21:43
ba29b3a to
a2c00be
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 22, 2026 00:51
86ed574 to
55f7640
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 22, 2026 00:51
a2c00be to
e758510
Compare
nicohrubec
approved these changes
Jul 22, 2026
| import { assertEquals } from 'https://deno.land/std@0.212.0/assert/assert_equals.ts'; | ||
| import { assertExists } from 'https://deno.land/std@0.212.0/assert/assert_exists.ts'; | ||
|
|
||
| function resetGlobals(): void { |
Member
There was a problem hiding this comment.
l: are these helpers the same in all tests? if yes maybe worth extracting out
JPeer264
approved these changes
Jul 22, 2026
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 22, 2026 14:42
55f7640 to
8d4883f
Compare
isaacs
requested review from
chargome,
msonnb and
mydea
and removed request for
a team
July 22, 2026 14:42
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
2 times, most recently
from
July 22, 2026 22:02
a100fe7 to
9d37f38
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 22, 2026 22:02
8d4883f to
5b72b0b
Compare
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 23, 2026 14:29
5b72b0b to
9f9dca3
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 23, 2026 14:29
9d37f38 to
cee6ad4
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 23, 2026 18:10
9f9dca3 to
b2b7f0f
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
2 times, most recently
from
July 23, 2026 20:46
14acde5 to
1414310
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 23, 2026 20:46
b2b7f0f to
632cfe9
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 23, 2026 21:19
632cfe9 to
d79eaf2
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 23, 2026 21:19
1414310 to
62951af
Compare
Comment on lines
+65
to
+74
| Deno.test('express instrumentation: orchestrion:express:handle channel produces a nested middleware span', async () => { | ||
| resetGlobals(); | ||
| const sink = transactionSink(); | ||
| init({ | ||
| dsn: 'https://username@domain/123', | ||
| tracesSampleRate: 1, | ||
| beforeSendTransaction: sink.beforeSendTransaction, | ||
| }); | ||
|
|
||
| const channel = tracingChannel('orchestrion:express:handle'); |
Contributor
There was a problem hiding this comment.
Bug: The test suite does not reset the global installedIntegrations array between tests, causing test isolation failures where integrations are not re-initialized correctly.
Severity: LOW
Suggested Fix
In the test setup file, add installedIntegrations.splice(0, installedIntegrations.length) to the test's beforeEach or equivalent setup function. This will clear the array and ensure each test runs with a clean slate, matching the pattern used in other integration tests.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: dev-packages/deno-integration-tests/suites/orchestrion-express/test.ts#L65-L74
Potential issue: A test isolation issue exists where global state is not properly reset
between test runs. Specifically, the `installedIntegrations` global array is not
cleared. This prevents Sentry integrations, such as the Express integration, from being
set up again in subsequent tests because their `setupOnce()` method is skipped. This can
lead to fragile tests that implicitly rely on state from previous tests, rather than
running in a clean, isolated environment. While a module-level `_isInstrumented` flag
also prevents re-instrumentation, the primary issue is the lack of global state reset in
the test suite's setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.